[SPARK-23310][CORE] Turn off read ahead input stream for unshafe shuffle reader #20492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitalkedia
changed the title
|
Test build #87014 has finished for PR 20492 at commit
|
| @@ -77,7 +77,7 @@ public UnsafeSorterSpillReader( | |||
| SparkEnv.get().conf().getDouble("spark.unsafe.sorter.spill.read.ahead.fraction", 0.5); | |||
|
|
|||
| final boolean readAheadEnabled = SparkEnv.get() != null && | |||
| SparkEnv.get().conf().getBoolean("spark.unsafe.sorter.spill.read.ahead.enabled", true); | |||
| SparkEnv.get().conf().getBoolean("spark.unsafe.sorter.spill.read.ahead.enabled", false); | |||
There was a problem hiding this comment.
Can we add a comment here to add more context? Perhaps also link a JIRA/TODO to re-enable this in 2.4?
There was a problem hiding this comment.
Good point, added more context to it.
|
Just a minor comment, LGTM. Thanks! |
sitalkedia
force-pushed
the
turn_off_async_inputstream
branch
from
36b099b to
732cf9e
Compare
|
Test build #87059 has finished for PR 20492 at commit
|
|
LGTM |
|
merging this to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
Feb 5, 2018
…fle reader To fix regression for TPC-DS queries Author: Sital Kedia <[email protected]> Closes #20492 from sitalkedia/turn_off_async_inputstream. (cherry picked from commit 03b7e12) Signed-off-by: Sameer Agarwal <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Feb 6, 2018
## What changes were proposed in this pull request? This is a follow-up of #20492 which broke lint-java checks. This pr fixes the lint-java issues. ``` [ERROR] src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java:[79] (sizes) LineLength: Line is longer than 100 characters (found 114). ``` ## How was this patch tested? Checked manually in my local environment. Author: Takuya UESHIN <[email protected]> Closes #20514 from ueshin/issues/SPARK-23310/fup1. (cherry picked from commit 7db9979) Signed-off-by: Marcelo Vanzin <[email protected]>
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Feb 6, 2018
## What changes were proposed in this pull request? This is a follow-up of apache#20492 which broke lint-java checks. This pr fixes the lint-java issues. ``` [ERROR] src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java:[79] (sizes) LineLength: Line is longer than 100 characters (found 114). ``` ## How was this patch tested? Checked manually in my local environment. Author: Takuya UESHIN <[email protected]> Closes apache#20514 from ueshin/issues/SPARK-23310/fup1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix regression for TPC-DS queries